Skip to content

CHIA-3736 Avoid recomputing skipped transaction ID in create_bundle_from_mempool_items #20055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

CHIA-3736 Avoid recomputing skipped transaction ID in create_bundle_from_mempool_items #20055

merged 1 commit into from
Sep 11, 2025

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

We already fetch the transaction ID as part of iterating through transactions. There is no need to recompute it again out of the item's spend bundle.

Current Behavior:

New Behavior:

Testing Notes:

@AmineKhaldi AmineKhaldi self-assigned this Sep 10, 2025
@AmineKhaldi AmineKhaldi added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Sep 10, 2025
@AmineKhaldi AmineKhaldi marked this pull request as ready for review September 11, 2025 09:46
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner September 11, 2025 09:46
@pmaslana pmaslana merged commit 23ad961 into Chia-Network:main Sep 11, 2025
345 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees

@AmineKhaldi AmineKhaldi

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmineKhaldi @arvidn @pmaslana